[PATCH] D86343: [PowerPC] Use SDISel instead of FISel for calls and TOC-based accesses with PC-Rel

Victor Huang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 24 14:16:51 PDT 2020


NeHuang accepted this revision as: NeHuang.
NeHuang added a comment.

LGTM. Only a nit can be addressed while committing the patch.



================
Comment at: llvm/lib/Target/PowerPC/PPCFastISel.cpp:1570
 
+  // If we are a PC-Rel function, let SDISel handle the call.
+  if (Subtarget->isUsingPCRelativeCalls())
----------------
nit: `if this is a`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86343/new/

https://reviews.llvm.org/D86343



More information about the llvm-commits mailing list