[PATCH] D86312: [X86] Copy the tuning features and scheduler model from pentium4/x86-64 to generic

Mon Aug 24 14:03:18 PDT 2020

craig.topper added a comment.

In D86312#2234606 <https://reviews.llvm.org/D86312#2234606>, @spatel wrote:

> This seems alright, but I lost track of how we got here and where we are going. :)
> D83913 <https://reviews.llvm.org/D83913> added a handful of tuning flags to the Pentium4 model, and we're transferring those over to "generic" in this patch. So we will undo the Pentium4 changes eventually, but that requires some other change?

Yep. I'm working on a clang patch to set the recently added "tune-cpu" attribute to "generic" by default. While the "target-cpu" attribute will default to "pentium4" or "x86-64". That patch depends on this patch. Once that's in place we can remove the recent changes to pentium4.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86312/new/

https://reviews.llvm.org/D86312