[PATCH] D75025: [DSE,MSSA] Cache accesses with/without reachable read-clobbers.

Alina Sbirlea via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 24 13:16:01 PDT 2020


asbirlea accepted this revision.
asbirlea added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/Transforms/Scalar/DeadStoreElimination.cpp:1882
 
+    // Optimistically collect all accesses we for reads. If we do not find any
+    // read clobbers, add them to the cache.
----------------
Delete "we".


================
Comment at: llvm/lib/Transforms/Scalar/DeadStoreElimination.cpp:1908
+        LLVM_DEBUG(dbgs() << " ... bail out, discovered that " << *UseAccess
+                          << " is has a read-clobber earlier.\n");
+        return None;
----------------
Remove "is"


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75025/new/

https://reviews.llvm.org/D75025



More information about the llvm-commits mailing list