[PATCH] D86472: [Scalarizer] Avoid updating the name of globals

Mon Aug 24 12:24:23 PDT 2020

bjope added a comment.

In D86472#2234113 <https://reviews.llvm.org/D86472#2234113>, @lebedev.ri wrote:

> @bjope thanks! bugreport kinda skimmed my attention span, i was going to re-look today-ish.
> I think this looks fine. The another alternative would be to only do that if the value-to-be-renamed is an instruction,
> but then i'm not sure it's an improvement if we rename something that we reused.

Yes, I actually experimented with adding an isa<Instruction> check first. But then I figured there could be more uses of the scalar value that is extraced from the vector, so changing the name of that value might be more confusing compared to keeping its name. So when comparing the result I preferred this way of solving it.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86472/new/

https://reviews.llvm.org/D86472