[PATCH] D83404: [PowerPC][PCRelative] Thread Local Storage Support for Local Exec

Mon Aug 24 12:09:12 PDT 2020

stefanp added inline comments.

================
Comment at: llvm/test/CodeGen/PowerPC/pcrel-tls-local-exec.ll:30
+; CHECK-S-NEXT:    paddi r3, r13, x at TPREL, 0
+; CHECK-S-NEXT:    lwz r3, 0(r3)
+; CHECK-S-NEXT:    blr
----------------
stefanp wrote:
> I just realized this issue this morning.
> We can probably do better here. 
> Instead of:
> ```
> paddi r3, r13, x at TPREL, 0
> lwz r3, <OFFSET>(r3)
> ```
> we can probably generate:
> ```
> plwz r3, x at TPREL+<OFFSET>(r13)
> ```
> Where <OFFSET> is just some value.
> 
After an internal discussion it has been decided that we can leave this improvement for another patch. At this point I would say that we should just extend the test case to include offsets but not implement the merging of those two instructions.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83404/new/

https://reviews.llvm.org/D83404