[PATCH] D86306: [InstCombine] PHI-of-insertvalues -> insertvalue-of-PHI's
Roman Lebedev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Aug 24 11:57:43 PDT 2020
lebedev.ri added inline comments.
================
Comment at: llvm/lib/Transforms/InstCombine/InstCombinePHI.cpp:313
+ std::array<PHINode *, 2> NewOperands;
+ for (int OpIdx : seq(0U, 2U)) {
+ auto *&NewOperand = NewOperands[OpIdx];
----------------
spatel wrote:
> Testing my limits of C++... is seq() better/different than just listing the values as `{0, 1}`?
Right, in this case it's not, will change.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86306/new/
https://reviews.llvm.org/D86306
More information about the llvm-commits
mailing list