[PATCH] D84414: [RISCV] Support Shadow Call Stack

Sam Elliott via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 24 11:47:04 PDT 2020


lenary added a comment.

In D84414#2234327 <https://reviews.llvm.org/D84414#2234327>, @pcc wrote:

> FWIW, on aarch64 we decided to make `-fsanitize=shadow-call-stack` require the x18 reservation (instead of implying it) to try to avoid ABI mismatch problems. That is, it should be safe to mix and match code compiled with and without `-fsanitize=shadow-call-stack`. If we make `-fsanitize=shadow-call-stack` imply the x18 reservation, it makes it more likely that someone will accidentally build and link in incompatible code that does not reserve x18.

Ok, that approach does also make sense.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84414/new/

https://reviews.llvm.org/D84414



More information about the llvm-commits mailing list