[PATCH] D85740: Universal MachO: support LLVM IR objects

Shoaib Meenai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 24 10:52:29 PDT 2020


smeenai added a comment.

I think llvm-libtool-darwin would also need some adjustments to handle bitcode objects, archives, and universal binaries. That's definitely out of scope for this diff, but I'm just flagging it as another tool with missing bitcode support.



================
Comment at: llvm/include/llvm/Object/MachOUniversalWriter.h:19
 #include "llvm/Object/Binary.h"
+#include "llvm/Object/IRObjectFile.h"
 #include "llvm/Object/MachO.h"
----------------
Nit: how come you're including the header here instead of forward declaring `IRObjectFile`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85740/new/

https://reviews.llvm.org/D85740



More information about the llvm-commits mailing list