[PATCH] D86446: [analyzer][docs][NFC] Document the ento namespace in the llvm/Lexicon

Whisperity via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 24 10:21:24 PDT 2020


whisperity added inline comments.


================
Comment at: llvm/docs/Lexicon.rst:100
+    The namespace containing the parts of the
+    `static analyzer <https://clang.llvm.org/docs/ClangStaticAnalyzer.html>`_.
+    It abbreviates to `entomology <https://en.m.wikipedia.org/wiki/Entomology>`_.
----------------
This lexicon is for the entirety of LLVM, not just Clang, so maybe we should write "Clang Static Analyser" proper.


================
Comment at: llvm/docs/Lexicon.rst:101
+    `static analyzer <https://clang.llvm.org/docs/ClangStaticAnalyzer.html>`_.
+    It abbreviates to `entomology <https://en.m.wikipedia.org/wiki/Entomology>`_.
+
----------------
rnkovacs wrote:
> I think it is the other way around, i.e. 'entomology' is abbreviated to 'ento'. You could write that 'it is an abbreviation of entomology'.
Why is the **mobile** version (`m.wikipedia`) linked? Also, you can Wikipedia shortlink in the following format. The shortlink will automatically properly redirect the user to the proper site based on their device configuration, but if a desktop user opens `m.wikipedia` there isn't any "reverse redirect" for the proper desktop site...

I've also incorporated @rnkovacs's suggestion.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86446/new/

https://reviews.llvm.org/D86446



More information about the llvm-commits mailing list