[PATCH] D86462: [llvm-readelf][test] - Refine the sections-ext.test

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 24 07:59:03 PDT 2020


grimar created this revision.
grimar added reviewers: jhenderson, MaskRay.
Herald added subscribers: rupprecht, sunfish, sbc100, emaste.
Herald added a reviewer: espindola.
Herald added a project: LLVM.
grimar requested review of this revision.
Herald added a subscriber: aheejin.

The `sections-ext.test` is a test for ELF that is used
to test `--st`, `--sr` and `--sd` extension options for `-S`.

There are 2 problems with it:

1. It is broken, because for CHECK lines it contains there is

no corresponding `FileCheck` call.

2. It uses the precompiled object: `trivial.obj.elf-i386`.

This is the last ELF test where `trivial.obj.elf-i386` is used so we can get rid of the binary
and use an YAML description.

Also, there is a `Inputs/trivial.ll` file that describes how `trivial*` objects
in `Inputs` folders are created. I've removed it from `ELF`, because it is not
actual anymore (we have no more input binaries created with the use of trivial.ll there)
and copied the refined versions of it to `COFF`, `MachO` and `wasm` Input folders.


https://reviews.llvm.org/D86462

Files:
  llvm/test/tools/llvm-readobj/COFF/Inputs/trivial.ll
  llvm/test/tools/llvm-readobj/ELF/Inputs/trivial.ll
  llvm/test/tools/llvm-readobj/ELF/Inputs/trivial.obj.elf-i386
  llvm/test/tools/llvm-readobj/ELF/sections-ext.test
  llvm/test/tools/llvm-readobj/MachO/Inputs/trivial.ll
  llvm/test/tools/llvm-readobj/wasm/Inputs/trivial.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D86462.287398.patch
Type: text/x-patch
Size: 14242 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200824/874c908a/attachment.bin>


More information about the llvm-commits mailing list