[PATCH] D86453: [AArch64] Support conversion between fp16 and fp128

[Anatoly Trosinenko via Phabricator via llvm-commits]

atrosinenko added inline comments.


================
Comment at: compiler-rt/lib/builtins/extendhftf2.c:1
+//===-- lib/extendhfsf2.c - half -> quad conversion ---------------*- C -*-===//
+//
----------------
`extendhfsf2.c` should probably be `extendhftf2.c`.


================
Comment at: compiler-rt/test/builtins/Unit/fp_test.h:85
 
-static inline int compareResultH(uint16_t result,
-                                 uint16_t expected)
+static inline int compareResultH(TYPE_FP16 result,
+                                 TYPE_FP16 expected)
----------------
Shouldn't it have `(TYPE_FP16 result, uint16_t expected)` arguments like other compareResultX functions (as if `fp_t result, rep_t expected`)? The same for `test_truncXfhf2(... , uint16_t expected)`: if I get it right, the common tradition for them is expressing the reference value as corresponding `uintXX_t`. Meanwhile, this is probably related to your changes to second test case from extendhfsf2_test.c - the original sources look quite suspicious to me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86453/new/

https://reviews.llvm.org/D86453