[PATCH] D86303: [ARM][MVE] Tail-predication: remove the BTC + 1 overflow checks
Sjoerd Meijer via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Aug 24 06:30:57 PDT 2020
SjoerdMeijer added inline comments.
================
Comment at: llvm/lib/Target/ARM/MVETailPredication.cpp:394
//
- auto *TC = SE->getSCEV(TripCount);
+ auto *TCDef = SE->getSCEV(TripCount);
unsigned SizeInBits = TripCount->getType()->getScalarSizeInBits();
----------------
samparker wrote:
> same kind of nit, I guess having scalar and vector trip count names would be most clear?
Yeah, it was a bit of an overloaded tripcount mess. I will update this and use these 2 terms:
- element count: the original scalar tripcount,
- tripcount = the (vector) tripcount.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86303/new/
https://reviews.llvm.org/D86303
More information about the llvm-commits
mailing list