[PATCH] D73475: [X86] Make sure we do not clobber RBX with mwaitx when used as a base pointer.

[pierre gousseau via Phabricator via llvm-commits]

pgousseau marked 2 inline comments as done.
pgousseau added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:25820
     }
+    case Intrinsic::x86_mwaitx: {
+      // If the current function needs the base pointer, RBX,
----------------
craig.topper wrote:
> Can we just always use MWAITX_DAG and use the !hasBasePointer part of the custom inserter?
I assumed there might be missed optimisations opportunities, but havent managed to find an example actually so always using MWAITX_DAG sounds good!


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:25838
+      unsigned Opcode = X86ISD::MWAITX_DAG;
+      SDValue Chain = DAG.getNode(Opcode, dl, {MVT::Other, MVT::Glue},
+                                  {Op->getOperand(0), Op->getOperand(2),
----------------
craig.topper wrote:
> Is the Glue result needed?
Removed! thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73475/new/

https://reviews.llvm.org/D73475