[PATCH] D86315: Test all CHECK-NOT in a block even if one fails
Thomas Preud'homme via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Aug 24 03:16:46 PDT 2020
thopre added inline comments.
================
Comment at: llvm/test/FileCheck/multiple-check-not-failures.txt:31
+CHECK-ERRORS-NEXT: {{^}}^~~{{$}}
+CHECK-ERRORS-NOT: multiple-check-not-failures.txt:[[#@LINE-14]]:12: error: CHECK-NOT: excluded string found in input
+CHECK-ERRORS-NOT: {{C}}HECK-NOT: baz
----------------
jhenderson wrote:
> I think this line is a little too precise for a -NOT pattern - a slight change to the message would result in the check no longer doing anything useful.
>
> You could probably just get away with something like `CHECK-ERRORS-NOT: error:`
I had to disable --dump-input for that because otherwise it shows the error again and the CHECK-NOT fails.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86315/new/
https://reviews.llvm.org/D86315
More information about the llvm-commits
mailing list