[PATCH] D86403: [DAGCombine]: Fold X/Sqrt(X) to Sqrt(X).

Venkataramanan Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Aug 23 06:51:00 PDT 2020


venkataramanan.kumar.llvm added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/sqrt-fastmath.ll:494
   %sqrt = call <2 x double> @llvm.sqrt.v2f64(<2 x double> %x)
-  %r = fdiv arcp reassoc <2 x double> %x, %sqrt
+  %r = fdiv arcp nsz reassoc <2 x double> %x, %sqrt
   ret <2 x double> %r
----------------
spatel wrote:
> In general, I prefer to make test changes in a preliminary commit, so there's no question about the functional difference created by the change in the compiler code. I can do that on your behalf if you do not have commit privileges.
Sure please do on behalf me.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86403/new/

https://reviews.llvm.org/D86403



More information about the llvm-commits mailing list