[PATCH] D86212: [llvm-reduce] Skip chunks that lead to broken modules.
Roman Lebedev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Aug 22 13:57:29 PDT 2020
lebedev.ri accepted this revision.
lebedev.ri added a comment.
This revision is now accepted and ready to land.
I've been deliberating on this, but i guess this makes sense..
I personally always had `opt -verify` as the first interestingness check.
================
Comment at: llvm/tools/llvm-reduce/deltas/Delta.cpp:140
+ // Some reductions may result in invalid IR. Skip those chunks, to ensure
+ // the program stays valid.
----------------
I think it may be better to say:
```
// Some reductions may result in invalid IR. Skip such reductions.
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86212/new/
https://reviews.llvm.org/D86212
More information about the llvm-commits
mailing list