[PATCH] D86404: [llvm-reduce] Function body reduction: don't forget to unset comdat

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri accepted this revision.
lebedev.ri added a comment.
This revision is now accepted and ready to land.

LGTM.
It's an improvement, but i **really** think this should be moved into `deleteBody()` itself.

I believe you might also need to fix basic block and instruction reducers - can they not end up deleting everything?



================
Comment at: llvm/test/Reduce/remove-function-bodies-comdat.ll:2
+; RUN: llvm-reduce --test FileCheck --test-arg --check-prefixes=CHECK-ALL,CHECK-INTERESTINGNESS --test-arg %s --test-arg --input-file %s -o %t
+; RUN: cat %t | FileCheck --check-prefixes=CHECK-ALL,CHECK-FINAL %s
+
----------------
Should we also check that the `opt -verify` passes?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86404/new/

https://reviews.llvm.org/D86404