[PATCH] D86404: [llvm-reduce] Function body reduction: don't forget to unset comdat

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Aug 22 12:36:40 PDT 2020


lebedev.ri requested changes to this revision.
lebedev.ri added a comment.
This revision now requires changes to proceed.

After looking a bit more, i believe `deleteBody()` should do that.



================
Comment at: llvm/tools/llvm-reduce/deltas/ReduceFunctionBodies.cpp:33
+      F.setComdat(nullptr);
+      F.setLinkage(llvm::GlobalValue::ExternalLinkage);
+    }
----------------
Actually, `deleteBody()` already does that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86404/new/

https://reviews.llvm.org/D86404



More information about the llvm-commits mailing list