[llvm] 93af370 - Follow-up build fix for rGae6f78824031

Jeremy Morse via llvm-commits llvm-commits at lists.llvm.org
Sat Aug 22 11:10:01 PDT 2020


Author: Jeremy Morse
Date: 2020-08-22T19:09:30+01:00
New Revision: 93af37043b9c1a8ea47890ad2bcf277f9b36c47d

URL: https://github.com/llvm/llvm-project/commit/93af37043b9c1a8ea47890ad2bcf277f9b36c47d
DIFF: https://github.com/llvm/llvm-project/commit/93af37043b9c1a8ea47890ad2bcf277f9b36c47d.diff

LOG: Follow-up build fix for rGae6f78824031

One of the bots objects to brace-initializing a tuple:

  http://lab.llvm.org:8011/builders/clang-cmake-x86_64-sde-avx512-linux/builds/43595/steps/build%20stage%201/logs/stdio

As the tuple constructor is apparently explicit. Fall back to the (not
as pretty) explicit construction of a tuple. I'd thought this was
permitted behaviour; will investigate why this fails later.

Added: 
    

Modified: 
    llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.cpp b/llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.cpp
index 25f474ca4477..a0e85c82868f 100644
--- a/llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.cpp
+++ b/llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.cpp
@@ -2347,7 +2347,7 @@ std::tuple<Optional<ValueIDNum>, bool> InstrRefBasedLDV::pickVPHILoc(
 
   // If there were no locations at all, return an empty result.
   if (Locs.empty())
-    return {None, false};
+    return std::tuple<Optional<ValueIDNum>, bool>(None, false);
 
   // Lambda for seeking a common location within a range of location-sets.
   typedef SmallVector<SmallVector<LocIdx, 4>, 8>::iterator LocsIt;
@@ -2382,12 +2382,12 @@ std::tuple<Optional<ValueIDNum>, bool> InstrRefBasedLDV::pickVPHILoc(
   }
 
   if (!TheLoc)
-    return {None, false};
+    return std::tuple<Optional<ValueIDNum>, bool>(None, false);
 
   // Return a PHI-value-number for the found location.
   LocIdx L = *TheLoc;
   ValueIDNum PHIVal = {(unsigned)MBB.getNumber(), 0, L};
-  return {PHIVal, ValidForAllLocs};
+  return std::tuple<Optional<ValueIDNum>, bool>(PHIVal, ValidForAllLocs);
 }
 
 std::tuple<bool, bool> InstrRefBasedLDV::vlocJoin(


        


More information about the llvm-commits mailing list