[PATCH] D86319: [Attributor] Introduce module slice.

Shinji Okumura via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Aug 22 05:31:47 PDT 2020


okura added inline comments.


================
Comment at: llvm/test/Transforms/Attributor/IPConstantProp/musttail-call.ll:100
 ; IS__CGSCC____-NEXT:    [[I1:%.*]] = call i32 @external()
-; IS__CGSCC____-NEXT:    ret i8* null
+; IS__CGSCC____-NEXT:    unreachable
 ;
----------------
jdoerfert wrote:
> This looks wrong though. Need to verify.
This is because of AANoUndef implementation. I have made a patch for this.  D86396


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86319/new/

https://reviews.llvm.org/D86319



More information about the llvm-commits mailing list