[PATCH] D86322: [flang] Fix bug accessing implicit variable in specification expression

[Tim Keith via Phabricator via llvm-commits]

tskeith updated this revision to Diff 287150.
tskeith added a comment.

Address review comments

Create common block symbol in PreSpecificationConstruct so that common
block objects can immediately be added to them. Remove the corresponding
code in the main visitor and `commonBlockInfo_.curr`. Eliminate the
InCommonBlock flag because the InCommonBlock function can replace it.
Move that function to tools.{h,cpp}.

Enhance parser::Unwrap to unwrap Statement and UnlabeledStatement and
make use of that in PreSpecificationConstruct.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86322/new/

https://reviews.llvm.org/D86322

Files:
  flang/include/flang/Parser/tools.h
  flang/include/flang/Semantics/symbol.h
  flang/include/flang/Semantics/tools.h
  flang/lib/Semantics/check-declarations.cpp
  flang/lib/Semantics/compute-offsets.cpp
  flang/lib/Semantics/expression.cpp
  flang/lib/Semantics/resolve-names.cpp
  flang/lib/Semantics/tools.cpp
  flang/test/Semantics/block-data01.f90
  flang/test/Semantics/implicit11.f90
  flang/test/Semantics/modfile21.f90
  flang/test/Semantics/resolve42.f90

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D86322.287150.patch
Type: text/x-patch
Size: 28768 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200822/8418a4f9/attachment.bin>