[PATCH] D83500: [PowerPC][Power10] Implement custom codegen for the vec_replace_elt and vec_replace_unaligned builtins.
    Amy Kwan via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Fri Aug 21 18:42:26 PDT 2020
    
    
  
amyk updated this revision to Diff 287142.
amyk added a comment.
Address review comments:
- Further consolidate the custom codegen of the two builtins
- Add SemaChecking for if the third argument is a constant, if the third argument is in range and if the second argument is the same type as the element type of the first argument
- Add extra test to test the semantic checks that were added
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83500/new/
https://reviews.llvm.org/D83500
Files:
  clang/include/clang/Basic/BuiltinsPPC.def
  clang/lib/CodeGen/CGBuiltin.cpp
  clang/lib/Headers/altivec.h
  clang/lib/Sema/SemaChecking.cpp
  clang/test/CodeGen/builtins-ppc-p10vector.c
  clang/test/CodeGen/builtins-ppc-vec-ins-error.c
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D83500.287142.patch
Type: text/x-patch
Size: 16198 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200822/efb9dad8/attachment.bin>
    
    
More information about the llvm-commits
mailing list