[PATCH] D86387: Fix frame pointer layout on AArch64 Linux.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64MachineFunctionInfo.h:243
+
+      if (!AnyRegistersCounted) {
+        return 0;
----------------
Omit braces

http://llvm.org/docs/CodingStandards.html#don-t-use-braces-on-simple-single-statement-bodies-of-if-else-loop-statements


================
Comment at: llvm/test/CodeGen/AArch64/framelayout-fp-csr.ll:13
+}
+; CHECK-LABEL: test1
+; CHECK: str     d8, [sp, #-32]!
----------------
Append a colon to make the label unique `test1:`


================
Comment at: llvm/test/CodeGen/AArch64/framelayout-fp-csr.ll:14
+; CHECK-LABEL: test1
+; CHECK: str     d8, [sp, #-32]!
+; CHECK-NEXT: stp     x29, x30, [sp, #16]
----------------
FileCheck ignores whitespace change by default. It looks better when CHECK and CHECK-NEXT's content is aligned.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86387/new/

https://reviews.llvm.org/D86387