[PATCH] D70378: [LLD][COFF] Cover usage of LLD as a library

Alexandre Ganea via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 21 15:29:16 PDT 2020


aganea added inline comments.


================
Comment at: lld/tools/lld/lld.cpp:228
+  // usages of `not --crash`.
+  if (*mainRet < 0)
+    LLVM_BUILTIN_TRAP;
----------------
@MaskRay I've also replaced the `LLVM_BUILD_TRAP` with `raise`, just to properly throw the right signal (also take a look at CrashRecoveryContext.cpp). Since you're more knowledgable than me in this area, let me know you think of a better way.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70378/new/

https://reviews.llvm.org/D70378



More information about the llvm-commits mailing list