[PATCH] D84327: [SCEVExpander] Add helper to clean up instrs inserted while expanding.

Fri Aug 21 12:52:08 PDT 2020

rupprecht added a comment.

In D84327#2230474 <https://reviews.llvm.org/D84327#2230474>, @fhahn wrote:

> I recommitted the change in 8eded24bf46c05ffd110d521f58320cdee93866e <https://reviews.llvm.org/rG8eded24bf46c05ffd110d521f58320cdee93866e> with a fix for the issue reported by @rupprecht, which was caused due to the expander also adding existing, re-used values to InsertedValues, which we should not try to remove.

I can confirm the recommit looks good, thanks!

I forgot to mention we actually saw this as a miscompile when building w/ a release build of clang; the assertion caught the underlying issue. Both the miscompile (with the release build) and the assertion (with the debug build) are gone now.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84327/new/

https://reviews.llvm.org/D84327