[PATCH] D82763: MIR: Infer not-SSA for subregister defs
Quentin Colombet via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 21 11:47:23 PDT 2020
qcolombet accepted this revision.
qcolombet added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: llvm/lib/CodeGen/MIRParser/MIRParser.cpp:330
+ // FIXME: def_empty should count as an SSA violation.
+ // Subregister defs are invalid in SSA.
+ const MachineOperand *RegDef = MRI.getOneDef(Reg);
----------------
Replying to the FIXME: Unclear, if Reg is a reserved reg, maybe that's fine.
I could also be that we removed the implicit_defs.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82763/new/
https://reviews.llvm.org/D82763
More information about the llvm-commits
mailing list