[PATCH] D86335: [RegisterPressure] Use Register instead of unsigned for RegUnit

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 21 06:33:41 PDT 2020


arsenm added a comment.

RegUnits are *not* registers, so you should not use Register for them



================
Comment at: llvm/lib/Target/AMDGPU/SIMachineScheduler.cpp:351
   for (const auto &RegMaskPair : RPTracker.getPressure().LiveInRegs) {
-    if (Register::isVirtualRegister(RegMaskPair.RegUnit))
       LiveInRegs.insert(RegMaskPair.RegUnit);
----------------
This query doesn't make any sense


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86335/new/

https://reviews.llvm.org/D86335



More information about the llvm-commits mailing list