[PATCH] D83404: [PowerPC][PCRelative] Thread Local Storage Support for Local Exec
Stefan Pintilie via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 21 05:55:41 PDT 2020
stefanp requested changes to this revision.
stefanp added a comment.
This revision now requires changes to proceed.
Also, please add a test where the offset is not zero.
So the assembly would be for example:
paddi 3, 13, x at TPREL+8, 0
Sorry to have approved it and then requested changes. :(
================
Comment at: llvm/test/CodeGen/PowerPC/pcrel-tls-local-exec.ll:30
+; CHECK-S-NEXT: paddi r3, r13, x at TPREL, 0
+; CHECK-S-NEXT: lwz r3, 0(r3)
+; CHECK-S-NEXT: blr
----------------
I just realized this issue this morning.
We can probably do better here.
Instead of:
```
paddi r3, r13, x at TPREL, 0
lwz r3, <OFFSET>(r3)
```
we can probably generate:
```
plwz r3, x at TPREL+<OFFSET>(r13)
```
Where <OFFSET> is just some value.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83404/new/
https://reviews.llvm.org/D83404
More information about the llvm-commits
mailing list