[PATCH] D86344: [FileCheck] Move FileCheck implementation out of LLVMSupport into its own library

Fri Aug 21 05:34:20 PDT 2020

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

All looks good to me, with the exception of a couple of inline nits, and the fact that I know nothing about the modulemap stuff (but the latter looks right, based on what is done elsewhere within it).

================
Comment at: llvm/include/llvm/FileCheck/FileCheck.h:13-14

 #ifndef LLVM_SUPPORT_FILECHECK_H
 #define LLVM_SUPPORT_FILECHECK_H

----------------
Include guards need updating.

================
Comment at: llvm/lib/FileCheck/FileCheckImpl.h:15-16

 #ifndef LLVM_LIB_SUPPORT_FILECHECKIMPL_H
 #define LLVM_LIB_SUPPORT_FILECHECKIMPL_H

----------------
Ditto.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86344/new/

https://reviews.llvm.org/D86344