[PATCH] D67767: [AMDGPU] Add llvm.amdgcn.wqm.demote intrinsic

[Jay Foad via Phabricator via llvm-commits]

foad added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIWholeQuadMode.cpp:778-779
+          break;
+        unsigned Src = MBBI->getOperand(1).getReg();
+        if (!Register::isVirtualRegister(Src) && MBB.isLiveIn(Src)) {
+          MBBI++;
----------------
critson wrote:
> arsenm wrote:
> > use Register
> I assume you mean the variable name Src -> Register?
I'm pretty sure he meant s/unsigned Src/Register Src/. clang-tidy thinks the same.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67767/new/

https://reviews.llvm.org/D67767