[PATCH] D85519: [llvm-readobj/elf] - Refine the code for broken PT_DYNAMIC segment diagnostic.
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 21 03:35:24 PDT 2020
jhenderson added a comment.
In D85519#2230138 <https://reviews.llvm.org/D85519#2230138>, @grimar wrote:
> In D85519#2230120 <https://reviews.llvm.org/D85519#2230120>, @jhenderson wrote:
>
>> Looks okay, but what was causing the UBSAN failure?
>
> This line:
>
> const uint8_t *Addr = Obj->base() + Offset;
>
> I believe pointers are not allowed to overflow.
Makes sense, thanks!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85519/new/
https://reviews.llvm.org/D85519
More information about the llvm-commits
mailing list