[PATCH] D86300: [OpenMPOpt][SplitMemTransfer] Getting values stored in offload arrays

Stefan Stipanovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 21 02:56:23 PDT 2020


sstefan1 added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:488
+    for (auto &I : *BB) {
+      if (&I == &Before) break;
+
----------------
I think it is preferred to have this on the new line. There's at least one more below.

Also I think it is preferred to use the actual type in the loop above.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86300/new/

https://reviews.llvm.org/D86300



More information about the llvm-commits mailing list