[PATCH] D77152: [SelectionDAG] Better legalization for FSHL and FSHR

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 21 02:27:56 PDT 2020


asb added a comment.

No objections accepting from the RISC-V side. I don't have a set of execution tests for the fshl/fshr changes to validate them, but I didn't see anything obviously wrong. The changes primarily affect the (still experimental) bitmanip extension also, so the bar for review is somewhat lower. The change does seem to improve srliw lowering in a few places in the GCC torture suite as well (in a way that is both correct and beneficial).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77152/new/

https://reviews.llvm.org/D77152



More information about the llvm-commits mailing list