[PATCH] D86305: [DebugInfo]Added support for representing Fortran assumed length strings

[Sourabh Singh Tomar via Phabricator via llvm-commits]

SouraVX added inline comments.


================
Comment at: llvm/include/llvm/Bitcode/LLVMBitCodes.h:342
+  METADATA_COMMON_BLOCK = 44,           // [distinct, scope, name, variable,...]
+  METADATA_STRING_TYPE = 45             // [distinct, name, size, align,...]
 };
----------------
schweitz wrote:
> Wasn't this gap in the numbering because METADATA_STRING_TYPE originally came before METADATA_COMMON_BLOCK in my original changes?
For the record yes! Looking at the history, GAP 40 - 44  was introduced in when COOMMON BLOCK was introduced in D54327.
It shouldn't cause an issue. But for uniformities sake should we make it 41 ? this will reduce the GAP and we can follow this for upcoming in this direction.
@aprantl you want to add on this ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86305/new/

https://reviews.llvm.org/D86305