[PATCH] D86331: Fix a cmake failure on Windows when LLVM_ENABLE_TERMINFO is set

Nathan Lanza via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 20 22:07:52 PDT 2020


lanza created this revision.
Herald added subscribers: llvm-commits, hiraditya, mgorny.
Herald added a project: LLVM.
lanza requested review of this revision.

The check that uniques these to variables is done under the condition
`NOT PURE_WINDOWS` and thus LLVM_ENABLE_TERMINFO can be 1 while
TERMINFO_LIB can be undefined. This is just to fix a build failure.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D86331

Files:
  llvm/lib/Support/CMakeLists.txt


Index: llvm/lib/Support/CMakeLists.txt
===================================================================
--- llvm/lib/Support/CMakeLists.txt
+++ llvm/lib/Support/CMakeLists.txt
@@ -224,7 +224,7 @@
   set(llvm_system_libs ${llvm_system_libs} "${zlib_library}")
 endif()
 
-if(LLVM_ENABLE_TERMINFO)
+if(LLVM_ENABLE_TERMINFO AND TERMINFO_LIB)
   get_system_libname(${TERMINFO_LIB} terminfo_library)
   set(llvm_system_libs ${llvm_system_libs} "${terminfo_library}")
 endif()


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D86331.286952.patch
Type: text/x-patch
Size: 474 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200821/0402dfb1/attachment.bin>


More information about the llvm-commits mailing list