[PATCH] D85069: [RISCV] add the MC layer support of riscv vector Zvamo extension

[Hsiangkai Wang via Phabricator via llvm-commits]

HsiangKai added a comment.

Just a couple of nits, but otherwise it LGTM.



================
Comment at: llvm/lib/Target/RISCV/RISCVInstrFormatsV.td:330
+
+class RVInstVAMO<RISCVAMOOP amoop, bits<3> width, dag outs, 
+                 dag ins, string opcodestr, string argstr>
----------------
Redundant space at the end.


================
Comment at: llvm/lib/Target/RISCV/RISCVSchedRocket32.td:20
   let CompleteModel = 1;
-  let UnsupportedFeatures = [HasStdExtV];
+  let UnsupportedFeatures = [HasStdExtV, HasStdExtZvamo];
 }
----------------
Rebase on master to include HasStdExtZvlsseg.


================
Comment at: llvm/lib/Target/RISCV/RISCVSchedRocket64.td:19
   let MispredictPenalty = 3;
-  let UnsupportedFeatures = [HasStdExtV];
+  let UnsupportedFeatures = [HasStdExtV, HasStdExtZvamo];
 }
----------------
Rebase on master to include HasStdExtZvlsseg.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85069/new/

https://reviews.llvm.org/D85069