[PATCH] D86275: [DSE,MemorySSA] Use BatchAA for AA queries.

[Alina Sbirlea via Phabricator via llvm-commits]

asbirlea added a comment.

The improvement looks great!

The alias cache relies on MemoryLocations and should be valid. The nonEscaping cache relies on pointers, so here I had reservations on what happens if a store is in cache and gets removed. There are no future queries for it, and there are no new values in DSE that may reuse that pointer. So I *think* this is correct, but it needs some documentation in the pass on why BatchAA is ok to use here.
I think it's necessary for the assumptions to be made clear in case the pass changes for some reason and breaks those assumptions; also if new caches are added in BatchAA, its users should have it clearly specified on what behavior they rely.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86275/new/

https://reviews.llvm.org/D86275