[PATCH] D86170: PrintStackTrace: don't symbolize if LLVM_DISABLE_SYMBOLIZATION is set

[David Blaikie via Phabricator via llvm-commits]

dblaikie added inline comments.


================
Comment at: llvm/utils/not/not.cpp:37-43
+#ifdef _WIN32
+    SetEnvironmentVariableA("LLVM_DISABLE_CRASH_REPORT", "1");
+    SetEnvironmentVariableA("LLVM_DISABLE_SYMBOLIZATION", "1");
+#else
+    setenv("LLVM_DISABLE_CRASH_REPORT", "1", 0);
+    setenv("LLVM_DISABLE_SYMBOLIZATION", "1", 0);
+#endif
----------------
MaskRay wrote:
> dblaikie wrote:
> > Rather than adding non-portable code, any chance of passing this environment variable into the child process creation in ExecuteAndWait?
> That requires to construct a vector<StringRef>. The complexity may not be lower.
Yeah, I'm not expecting it to be less code - but more portable/keeping the portability layers down in the System library in one place, etc.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86170/new/

https://reviews.llvm.org/D86170