[PATCH] D77924: ld128 demangle: allow space for 'L' suffix.
Elliott Hughes via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 20 16:02:48 PDT 2020
enh added a comment.
In D77924#2229360 <https://reviews.llvm.org/D77924#2229360>, @vvereschaka wrote:
> I ran the test directly on our aarch64 board.
thank you! my aarch64 device is dead right now, and thanks to working from home i can't just kick it :-(
> The output is the following
>
> ubuntu at jetson8:~$ ./t.tmp.exe
> Testing 29715 symbols.
> 1ILeeeEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEE -> <-0x1.cecececececececececececececep+11983
> Got instead: <-0x1.cecececececececececececececep+11983L>
> t.tmp.exe: C:/buildbot/temp/llvm-project/libcxxabi/test/test_demangle.pass.cpp:30001: void testFPLiterals(): Assertion `false' failed.
> Aborted (core dumped)
ah, crap, yeah, there's a bad copy and paste in the test (missing that trailing 'L').
fixed by https://reviews.llvm.org/D86321.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77924/new/
https://reviews.llvm.org/D77924
More information about the llvm-commits
mailing list