[PATCH] D86260: [CodeGen] Postprocess PHI nodes for callbr

Bill Wendling via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 20 15:28:10 PDT 2020


void marked an inline comment as done.
void added a comment.

In D86260#2229387 <https://reviews.llvm.org/D86260#2229387>, @jyknight wrote:

> The commit message is confusing for this -- this isn't a correctness fix, but a minor optimization, right?

I'm not convinced it's just an optimization, but I could be swayed. It seems to me that the value coming into the PHI shouldn't rely upon the semantics of the asm block. So for instance would this be incorrect?

  bb1:
    %eax = MOV 0
    INLINEASM_BR "mov 37, %eax"
    JMP return
  
  return:
    PHI bb1, 0 ...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86260/new/

https://reviews.llvm.org/D86260



More information about the llvm-commits mailing list