[PATCH] D81947: [PowerPC][PCRelative] Thread Local Storage Support for Initial Exec

Stefan Pintilie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 20 14:00:11 PDT 2020


stefanp accepted this revision as: stefanp.
stefanp added a comment.
This revision is now accepted and ready to land.

Couple of nits.
LGTM



================
Comment at: llvm/test/MC/PowerPC/pcrel-tls-initial-exec-address-load-reloc.s:18
+
+InitialExec:                            # @InitialExec
+	pld 3, x at got@tprel at pcrel(0), 1
----------------
nit:
You can delete the comment (`# @InitialExec`) here and just leave the label.


================
Comment at: llvm/test/MC/PowerPC/pcrel-tls-initial-exec-value-load-reloc.s:18
+
+InitialExecLoad:                        # @InitialExecLoad
+	pld 3, x at got@tprel at pcrel(0), 1
----------------
nit:
You can delete the comment and just leave the label.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81947/new/

https://reviews.llvm.org/D81947



More information about the llvm-commits mailing list