[PATCH] D86102: [libunwind] Ensure enough alignment for unw_cursor_t for SEH build configurations

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added inline comments.


================
Comment at: libunwind/include/libunwind.h:72
+}
+#if defined(_WIN32) && defined(__SEH__)
+__attribute__((aligned(16)))
----------------
compnerd wrote:
> Can you extract this into a separate declaration and use that please?  Its purely a readability concern:
> 
> ```
> #if defined(_WIN32) && defined(__SEH__)
> #define _LIBUNWIND_CURSOR_ALIGNMENT_ATTR __attribute__((__aligned__(16)))
> #else
> #define _LIBUNWIND_CURSOR_ALIGNMENT_ATTR
> #endif
> ```
Sure, can do. But doing it without the leading underscore, to keep it consistent with an existing such define further up in the file.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86102/new/

https://reviews.llvm.org/D86102