[PATCH] D86181: [lld-macho] Implement -ObjC

Saleem Abdulrasool via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 20 10:20:11 PDT 2020


compnerd accepted this revision.
compnerd added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lld/MachO/ObjC.cpp:27
+      StringRef sectname(sec.sectname, strnlen(sec.sectname, 16));
+      StringRef segname(sec.segname, strnlen(sec.segname, 16));
+      if ((segname == segment_names::data && sectname == "__objc_catlist") ||
----------------
Would you mind replacing `16` with `sizeof(llvm::MachO::section::sectname)`  and `sizeof(llvm::MachO::section::segname)` respectively?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86181/new/

https://reviews.llvm.org/D86181



More information about the llvm-commits mailing list