[PATCH] D85756: [DebugInstrRef][5/9] Substitute debug value numbers to handle optimisations

[Adrian Prantl via Phabricator via llvm-commits]

aprantl accepted this revision.
aprantl added a subscriber: vsk.
aprantl added a comment.
This revision is now accepted and ready to land.

@vsk We really need a richer API for MBB::erase that takes extra arguments and forces you to think about this.



================
Comment at: llvm/lib/CodeGen/TwoAddressInstructionPass.cpp:623
+    unsigned NewInstrNum = NewMI->getDebugInstrNum();
+    MF->makeDebugValueSubstitution(std::make_pair(OldInstrNum, OldIdx),
+                                   std::make_pair(NewInstrNum, NewIdx));
----------------
`MF->makeDebugValueSubstitution({OldInstrNum, OldIdx}, {NewInstrNum, NewIdx});` ?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85756/new/

https://reviews.llvm.org/D85756