[PATCH] D86262: [LoopIdiomRecognizePass] Options to disable part or the entire Loop Idiom Recognize Pass

Thu Aug 20 07:21:00 PDT 2020

lebedev.ri added a comment.

In D86262#2228420 <https://reviews.llvm.org/D86262#2228420>, @anhtuyen wrote:

> In D86262#2227781 <https://reviews.llvm.org/D86262#2227781>, @dfukalov wrote:
>
>> In D86262#2227676 <https://reviews.llvm.org/D86262#2227676>, @lebedev.ri wrote:
>>
>>> Why not just enhance DA?
>>
>> I agree with that, it seems to be better to improve DA. Is it feasible?
>
> I agree that DA can be improved, but I hope that the example below from @nemanjai  about libraries, which are highly tuned with respect to when/whether to call memset/memcpy functions provides another reason for this proposed change.

I'm not really sold on this. We have similar transform in InstCombine.
If the original problem is with DA, then that is what should be improved.

If this transform is a pessimization for some code, it would be good to actually see that code.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86262/new/

https://reviews.llvm.org/D86262