[PATCH] D83116: [DWARFYAML] Add support for referencing different abbrev tables.

Thu Aug 20 05:37:31 PDT 2020

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM. Thanks!

================
Comment at: llvm/test/tools/yaml2obj/ELF/DWARF/debug-info.yaml:658
+
+# NOTABLE: yaml2obj: error: abbrev table index must be less than or equal to the number of abbrev tables
+
----------------
Higuoxing wrote:
> jhenderson wrote:
> > Perhaps worth including the index and table count values in this error message to make it easier for people to identify the problem.
> I've included the abbrev table ID and compilation unit count values in test case (n). Can we prettify the error message in test case (i) in a follow-up patch?
That's fine.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83116/new/

https://reviews.llvm.org/D83116