[PATCH] D82788: [AMDGPU] Fix alignment requirements for 96bit and 128bit local loads and stores
Mirko Brkusanin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 20 04:02:57 PDT 2020
mbrkusanin updated this revision to Diff 286770.
mbrkusanin added a comment.
Issue was in (load 16, align 4, addrspace 3) which should not be legal for gfx7 but because of -global-isel-abort=0 if it crashes it would just give the same MIR as input.
I've changed those to align 8. D81638 <https://reviews.llvm.org/D81638> will update it again to pick DS_READ_B128 or DS_READ2_B64.
Also there was only run line for GFX7 but multiple checks lines. I added a new run line and removed redundant ones.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82788/new/
https://reviews.llvm.org/D82788
Files:
llvm/lib/Target/AMDGPU/AMDGPU.td
llvm/lib/Target/AMDGPU/AMDGPUSubtarget.cpp
llvm/lib/Target/AMDGPU/AMDGPUSubtarget.h
llvm/lib/Target/AMDGPU/AMDGPUTargetTransformInfo.h
llvm/lib/Target/AMDGPU/SIISelLowering.cpp
llvm/test/CodeGen/AMDGPU/GlobalISel/inst-select-load-local-128.mir
llvm/test/CodeGen/AMDGPU/GlobalISel/legalize-load-local.mir
llvm/test/CodeGen/AMDGPU/ds-combine-with-dependence.ll
llvm/test/CodeGen/AMDGPU/ds_read2.ll
llvm/test/CodeGen/AMDGPU/ds_write2.ll
llvm/test/Transforms/LoadStoreVectorizer/AMDGPU/merge-stores.ll
llvm/test/Transforms/LoadStoreVectorizer/AMDGPU/multiple_tails.ll
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D82788.286770.patch
Type: text/x-patch
Size: 46808 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200820/977d702d/attachment.bin>
More information about the llvm-commits
mailing list