[PATCH] D86263: [ELF] Keep st_type for symbol assignment

[George Rimar via Phabricator via llvm-commits]

grimar accepted this revision.
grimar added a comment.
This revision is now accepted and ready to land.

This LGTM with minor nit. Worth waiting for a final word from Peter too.



================
Comment at: lld/ELF/LinkerScript.h:61
   uint64_t alignment = 1;
+  uint8_t type = 0;
 
----------------
Deserves a comment I think. It is probably not that obvious that `type` is a symbol type.

Also, use `STT_NOTYPE` instead of `0`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86263/new/

https://reviews.llvm.org/D86263