[PATCH] D86149: [GlobalOpt] Fix another incorrect Modified status

[David Stenberg via Phabricator via llvm-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rG8206257cb86b: [GlobalOpt] Fix an incorrect Modified status (authored by dstenb).

Changed prior to commit:
  https://reviews.llvm.org/D86149?vs=286315&id=286759#toc

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86149/new/

https://reviews.llvm.org/D86149

Files:
  llvm/lib/Transforms/IPO/GlobalOpt.cpp
  llvm/test/Transforms/GlobalOpt/dead-store-status.ll


Index: llvm/test/Transforms/GlobalOpt/dead-store-status.ll
===================================================================
--- /dev/null
+++ llvm/test/Transforms/GlobalOpt/dead-store-status.ll
@@ -0,0 +1,43 @@
+; RUN: opt < %s -globalopt -S | FileCheck %s
+
+; When removing the store to @global in @foo, the pass would incorrectly return
+; false. This was caught by the pass return status check that is hidden under
+; EXPENSIVE_CHECKS.
+
+; CHECK: @global = internal unnamed_addr global i16* null, align 1
+
+; CHECK-LABEL: @foo
+; CHECK-NEXT: entry:
+; CHECK-NEXT: ret i16 undef
+
+ at global = internal unnamed_addr global i16* null, align 1
+
+; Function Attrs: nofree noinline norecurse nounwind writeonly
+define i16 @foo(i16 %c) local_unnamed_addr #0 {
+entry:
+  %local1.addr = alloca i16, align 1
+  store i16* %local1.addr, i16** @global, align 1
+  ret i16 undef
+}
+
+; Function Attrs: noinline nounwind writeonly
+define i16 @bar() local_unnamed_addr #1 {
+entry:
+  %local2 = alloca [1 x i16], align 1
+  %0 = bitcast [1 x i16]* %local2 to i8*
+  call void @llvm.lifetime.start.p0i8(i64 1, i8* nonnull %0)
+  %arraydecay = getelementptr inbounds [1 x i16], [1 x i16]* %local2, i16 0, i16 0
+  store i16* %arraydecay, i16** @global, align 1
+  call void @llvm.lifetime.end.p0i8(i64 1, i8* nonnull %0)
+  ret i16 undef
+}
+
+; Function Attrs: argmemonly nounwind willreturn
+declare void @llvm.lifetime.start.p0i8(i64 immarg, i8* nocapture) #2
+
+; Function Attrs: argmemonly nounwind willreturn
+declare void @llvm.lifetime.end.p0i8(i64 immarg, i8* nocapture) #2
+
+attributes #0 = { nofree noinline norecurse nounwind writeonly }
+attributes #1 = { noinline nounwind writeonly }
+attributes #2 = { argmemonly nounwind willreturn }
Index: llvm/lib/Transforms/IPO/GlobalOpt.cpp
===================================================================
--- llvm/lib/Transforms/IPO/GlobalOpt.cpp
+++ llvm/lib/Transforms/IPO/GlobalOpt.cpp
@@ -268,6 +268,7 @@
         I = J;
       } while (true);
       I->eraseFromParent();
+      Changed = true;
     }
   }
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D86149.286759.patch
Type: text/x-patch
Size: 2070 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200820/981b3a2a/attachment.bin>