[PATCH] D70365: intrinsics attribute opt-out list proposal.

[Stefan Stipanovic via Phabricator via llvm-commits]

sstefan1 added a comment.

In D70365#2227627 <https://reviews.llvm.org/D70365#2227627>, @mehdi_amini wrote:

> After this patch, `llvm-tblgen` in debug mode is 10x slower:
> Before:
>
>   $ time bin/llvm-tblgen -gen-global-isel -I ../llvm/test/TableGen/../../include -I ..//llvm/test/TableGen/Common -optimize-match-table=true ../llvm/test/TableGen/GlobalISelEmitter.td -o /tmp/test.cpp
>   
>   real	0m1.238s
>   user	0m0.970s
>   sys	0m0.274s
>
> After:
>
>   $ time bin/llvm-tblgen -gen-global-isel -I ../llvm/test/TableGen/../../include -I ..//llvm/test/TableGen/Common -optimize-match-table=true ../llvm/test/TableGen/GlobalISelEmitter.td -o /tmp/test.cpp
>   
>   real	0m11.671s
>   user	0m11.607s
>   sys	0m0.067s

Thanks for reporting this.
Numbers are similar in the release mode as well. The problem was that we go through all IntrProperties for every Intrinsic in search for ones that are default. However that can be done only once.

With reverted patch time in release was 9.43s for me, now it is 0.16s.

I'd need another approval from @arsenm or @nhaehnle.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70365/new/

https://reviews.llvm.org/D70365